From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: check the power well when
 redisabling VGA
Date: Wed, 14 Aug 2013 16:51:06 +0200
Message-ID: <20130814145106.GW9296@phenom.ffwll.local>
References: <1375471345-10217-1-git-send-email-przanoni@gmail.com>
	<20130805154612.GL22035@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com
	[209.85.215.174])
	by gabe.freedesktop.org (Postfix) with ESMTP id 73D51E67BF
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 14 Aug 2013 07:50:59 -0700 (PDT)
Received: by mail-ea0-f174.google.com with SMTP id z15so4869237ead.33
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 14 Aug 2013 07:50:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130805154612.GL22035@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Aug 05, 2013 at 05:46:12PM +0200, Daniel Vetter wrote:
> On Fri, Aug 02, 2013 at 04:22:24PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > If the power well is disabled VGA is guaranteed to be disabled.
> > 
> > This fixes unclaimed register messages that happen on suspend/resume.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67517
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Have you seen my other comment asking whether we could just force-enable
> the power well a bit earlier in the resume sequence instead? Imo that
> feels a notch more robust, since we didn't sprinkle tons of power well
> checks in all the other hw readout paths either.

Ok, I've merged this one here (plus comments and the follow-up patch)
instead of the other one.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch