From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 6.3/9] drm/i915: merge HSW and SNB PM irq handlers Date: Wed, 14 Aug 2013 12:21:09 -0700 Message-ID: <20130814192109.GE490@bwidawsk.net> References: <1375826239-3060-1-git-send-email-przanoni@gmail.com> <1376078677-24901-1-git-send-email-przanoni@gmail.com> <1376078677-24901-3-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 5918AE6AF6 for ; Wed, 14 Aug 2013 12:21:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376078677-24901-3-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 09, 2013 at 05:04:37PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Because hsw_pm_irq_handler does exactly what gen6_rps_irq_handler does > and also processes the 2 additional VEBOX bits. So merge those > functions and wrap the VEBOX bits on an IS_HASWELL check. This HSW > check isn't really necessary since the bits are reserved on > SNB/IVB/VLV, but it's a good documentation on who uses them. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_irq.c | 50 ++++++++++------------------------------- > 1 file changed, 12 insertions(+), 38 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index d9ebfb6..8ba5d0a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -939,28 +939,6 @@ static void snb_gt_irq_handler(struct drm_device *dev, > ivybridge_parity_error_irq_handler(dev); > } > > -/* Legacy way of handling PM interrupts */ > -static void gen6_rps_irq_handler(struct drm_i915_private *dev_priv, > - u32 pm_iir) > -{ > - /* > - * IIR bits should never already be set because IMR should > - * prevent an interrupt from being shown in IIR. The warning > - * displays a case where we've unsafely cleared > - * dev_priv->rps.pm_iir. Although missing an interrupt of the same > - * type is not a problem, it displays a problem in the logic. > - * > - * The mask bit in IMR is cleared by dev_priv->rps.work. > - */ > - > - spin_lock(&dev_priv->irq_lock); > - dev_priv->rps.pm_iir |= pm_iir & GEN6_PM_RPS_EVENTS; > - snb_disable_pm_irq(dev_priv, pm_iir & GEN6_PM_RPS_EVENTS); > - spin_unlock(&dev_priv->irq_lock); > - > - queue_work(dev_priv->wq, &dev_priv->rps.work); > -} > - > #define HPD_STORM_DETECT_PERIOD 1000 > #define HPD_STORM_THRESHOLD 5 > > @@ -1027,13 +1005,10 @@ static void dp_aux_irq_handler(struct drm_device *dev) > wake_up_all(&dev_priv->gmbus_wait_queue); > } > > -/* Unlike gen6_rps_irq_handler() from which this function is originally derived, > - * we must be able to deal with other PM interrupts. This is complicated because > - * of the way in which we use the masks to defer the RPS work (which for > - * posterity is necessary because of forcewake). > - */ > -static void hsw_pm_irq_handler(struct drm_i915_private *dev_priv, > - u32 pm_iir) > +/* The RPS events need forcewake, so we add them to a work queue and mask their > + * IMR bits until the work is done. Other interrupts can be processed without > + * the work queue. */ > +static void gen6_rps_irq_handler(struct drm_i915_private *dev_priv, u32 pm_iir) > { > if (pm_iir & GEN6_PM_RPS_EVENTS) { > spin_lock(&dev_priv->irq_lock); > @@ -1044,12 +1019,14 @@ static void hsw_pm_irq_handler(struct drm_i915_private *dev_priv, > queue_work(dev_priv->wq, &dev_priv->rps.work); > } > > - if (pm_iir & PM_VEBOX_USER_INTERRUPT) > - notify_ring(dev_priv->dev, &dev_priv->ring[VECS]); > + if (IS_HASWELL(dev_priv->dev)) { > + if (pm_iir & PM_VEBOX_USER_INTERRUPT) > + notify_ring(dev_priv->dev, &dev_priv->ring[VECS]); Make this HAS_VEBOX() instead of IS_HASWELL() > > - if (pm_iir & PM_VEBOX_CS_ERROR_INTERRUPT) { > - DRM_ERROR("VEBOX CS error interrupt 0x%08x\n", pm_iir); > - i915_handle_error(dev_priv->dev, false); > + if (pm_iir & PM_VEBOX_CS_ERROR_INTERRUPT) { > + DRM_ERROR("VEBOX CS error interrupt 0x%08x\n", pm_iir); > + i915_handle_error(dev_priv->dev, false); > + } > } > } > > @@ -1424,10 +1401,7 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg) > if (INTEL_INFO(dev)->gen >= 6) { > u32 pm_iir = I915_READ(GEN6_PMIIR); > if (pm_iir) { > - if (IS_HASWELL(dev)) > - hsw_pm_irq_handler(dev_priv, pm_iir); > - else > - gen6_rps_irq_handler(dev_priv, pm_iir); > + gen6_rps_irq_handler(dev_priv, pm_iir); > I915_WRITE(GEN6_PMIIR, pm_iir); > ret = IRQ_HANDLED; > } With the couple of small comments, these 3 patches are: Reviewed-by: Ben Widawsky Though after the IRC discussion you may want to discount my review. -- Ben Widawsky, Intel Open Source Technology Center