From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Paulo Zanoni <przanoni@gmail.com>,
intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: enable the power well before module unload
Date: Thu, 15 Aug 2013 13:32:58 +0200 [thread overview]
Message-ID: <20130815113258.GA776@phenom.ffwll.local> (raw)
In-Reply-To: <20130815110744.GD2806@strange.amr.corp.intel.com>
On Thu, Aug 15, 2013 at 12:07:44PM +0100, Damien Lespiau wrote:
> On Wed, Aug 14, 2013 at 02:40:37PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > Our driver initialization doesn't seem to be ready to load when the
> > power well is disabled: we hit a few "Unclaimed register" messages. So
> > do just like we already do for the suspend/resume path: enable the
> > power well before unloading.
> >
> > At some point we'll want to be able to survive suspend/resume and
> > load/unload with the power well disabled, but for now let's just fix
> > the regression.
> >
> > Regression introduced by the following commit:
> >
> > commit bf51d5e2cda5d36d98e4b46ac7fca9461e512c41
> > Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Date: Wed Jul 3 17:12:13 2013 -0300
> > drm/i915: switch disable_power_well default value to 1
> >
> > Bug can be reproduced by running the "module_reload" script from
> > intel-gpu-tools.
> >
> > Cc: stable@vger.kernel.org
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67813
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next (with the cc: stable dropped since module unload is a
developer feature), thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-08-15 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 17:40 [PATCH] drm/i915: enable the power well before module unload Paulo Zanoni
2013-08-15 11:07 ` [Intel-gfx] " Damien Lespiau
2013-08-15 11:32 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815113258.GA776@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox