From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: enable the power well before module unload Date: Thu, 15 Aug 2013 13:32:58 +0200 Message-ID: <20130815113258.GA776@phenom.ffwll.local> References: <1376502037-3058-1-git-send-email-przanoni@gmail.com> <20130815110744.GD2806@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130815110744.GD2806@strange.amr.corp.intel.com> Sender: stable-owner@vger.kernel.org To: Damien Lespiau Cc: Paulo Zanoni , intel-gfx@lists.freedesktop.org, Paulo Zanoni , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 15, 2013 at 12:07:44PM +0100, Damien Lespiau wrote: > On Wed, Aug 14, 2013 at 02:40:37PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Our driver initialization doesn't seem to be ready to load when the > > power well is disabled: we hit a few "Unclaimed register" messages. So > > do just like we already do for the suspend/resume path: enable the > > power well before unloading. > > > > At some point we'll want to be able to survive suspend/resume and > > load/unload with the power well disabled, but for now let's just fix > > the regression. > > > > Regression introduced by the following commit: > > > > commit bf51d5e2cda5d36d98e4b46ac7fca9461e512c41 > > Author: Paulo Zanoni > > Date: Wed Jul 3 17:12:13 2013 -0300 > > drm/i915: switch disable_power_well default value to 1 > > > > Bug can be reproduced by running the "module_reload" script from > > intel-gpu-tools. > > > > Cc: stable@vger.kernel.org > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67813 > > Signed-off-by: Paulo Zanoni > > Reviewed-by: Damien Lespiau Queued for -next (with the cc: stable dropped since module unload is a developer feature), thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch