From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 06/12] video/hdmi: Derive the bar data valid bit from the bar data fields Date: Thu, 15 Aug 2013 16:45:56 +0200 Message-ID: <20130815144555.GB16951@ulmo> References: <1376500755-30227-1-git-send-email-damien.lespiau@intel.com> <1376500755-30227-7-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2133084349==" Return-path: In-Reply-To: <1376500755-30227-7-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2133084349== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 14, 2013 at 06:19:09PM +0100, Damien Lespiau wrote: > Just like: >=20 > Author: Damien Lespiau > Date: Mon Aug 12 11:53:24 2013 +0100 >=20 > video/hdmi: Don't let the user of this API create invalid infoframes >=20 > But this time for the horizontal/vertical bar data present bits. >=20 > Signed-off-by: Damien Lespiau > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 > --- > drivers/video/hdmi.c | 5 +++-- > include/linux/hdmi.h | 2 -- > 2 files changed, 3 insertions(+), 4 deletions(-) Same comments as for patch 5. Although I begin to see some sense in this. Perhaps not exposing these boolean fields is a good idea after all. I wonder if we're excluding some particular use-case by not exposing these fields. Thierry --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJSDOmjAAoJEN0jrNd/PrOhWeMQAIP+bb+o0i4CIio0Z6XwO65k lCf9Xc7eEZtNJOScbJyEyY41V/RoI1L/4TURJ2o/EMrN1geXtTmIqOrAzlQHQz5d sykGc6JlfrhjIDbZ5Nok/9aOSZrv2jyiai+FllIRKngqhvU7udX4tFq5rFguWrRP CJ8eX2tNvodNUFrc9W85mP87u4WNVO4cHFsOvUPBwBz64qmD4s2G/Gv4NVwcf589 qKJElva/gWIe0Oe268kxxOcMBJvk+jYRvn8s9vU/FcnK/zS89IMMQ/U6l8XSJa7D Ns77T0cNzMflgqytuCB8tfAic8Pi/vumG0WmzAFvqveaX91aaUA0r2Fl3KVLtVhh yJgoTV3r3MhAx4jTqjjX6yHQ3Ks5oFueXHmmYmfRcm4SSD0mCPM2GzNgWvPUYs4K 9jguQvjYwuCjiGdQAhoAbw0QnmH4F1d/+G0/czBRakifAMD8ENe4hN86qN/cfpYn FnGt7fdwY2RvbHxMLbfaZDbXCUeHKuUJo8hpuHXueUJC6XFBOGManhDCVCLrlAfY zBEIjodxrrxVyBNoUpHrgS2PxvKczy9DH4gAwGSp/Xt4Y5h14ljsc1LFRZ5P2LIF /HCZkanmbndDPVVNSVqB2+I5KvkQVnWJUUhO6YsVyc20eUr+c7HlR4vDLy7OtK9G Xp+GorDifPe31slvW1gT =0UiS -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3-- --===============2133084349== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============2133084349==--