From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 07/12] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe Date: Thu, 15 Aug 2013 16:59:04 +0200 Message-ID: <20130815145904.GC16951@ulmo> References: <1376500755-30227-1-git-send-email-damien.lespiau@intel.com> <1376500755-30227-8-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1337216456==" Return-path: In-Reply-To: <1376500755-30227-8-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1337216456== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ghzN8eJ9Qlbqn3iT" Content-Disposition: inline --ghzN8eJ9Qlbqn3iT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 14, 2013 at 06:19:10PM +0100, Damien Lespiau wrote: [...] > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index ac84215..59c4748 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -286,6 +286,94 @@ ssize_t hdmi_audio_infoframe_pack(struct hdmi_audio_= infoframe *frame, > EXPORT_SYMBOL(hdmi_audio_infoframe_pack); > =20 > /** > + * hdmi_hdmi_infoframe_init() - initialize an HDMI vendor infoframe > + * @frame: HDMI vendor infoframe > + * > + * Returns 0 on success or a negative error code on failure. > + */ > +int hdmi_hdmi_infoframe_init(struct hdmi_hdmi_infoframe *frame) The hdmi_hdmi_ prefix is weird. Can't we come up with a better prefix? You refer to it as "HDMI vendor infoframe" in the comments, yet we already have struct hdmi_vendor_infoframe. Perhaps hdmi_3d_infoframe or hdmi_vendor_3d_infoframe would be better choices? > +{ > + memset(frame, 0, sizeof(*frame)); > + > + frame->type =3D HDMI_INFOFRAME_TYPE_VENDOR; > + frame->version =3D 1; > + > + /* 0 is a valid value for s3d_struct, so we use a special "not set" > + * value */ Nit: The block comment style is inconsistent again. > +/** > + * hdmi_hdmi_infoframe_pack() - write a HDMI vendor infoframe to binary = buffer > + * @frame: HDMI infoframe > + * @buffer: destination buffer > + * @size: size of buffer > + * > + * Packs the information contained in the @frame structure into a binary > + * representation that can be written into the corresponding controller > + * registers. Also computes the checksum as required by section 5.3.5 of > + * the HDMI 1.4 specification. I need to dig up that version of the specification. This infoframe doesn't seem to exist in 1.3. Thierry --ghzN8eJ9Qlbqn3iT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJSDOy4AAoJEN0jrNd/PrOh4UgP/3cHf4XvsXfzwtiSdtZcm8VD rNHXxwg8guadXDOX3/ILyU+7Z9wlcJZZcxrHeEWhNmNf9lYpvrpYhr7TX2cGNXvt AXNWqLwCelqMJRPzDyjQJMkKO9XMMIsoH4HMjqM8NCbkctif07HkNA2tdyX3y9DE q9g9IWJtXZbV7zh2hDA42kwPILe+dapNhVhIZMgIDVvjdH4NbweRLpmPLKwzysxf wM+KQYv4ixRpjAiArdk2rvRs51svDzcbMXr9n1xbfksmnyK41AYShqc9xjr/ru8I XXT9H2HVAWBhrMwONAODURA0XAkEfgMDsVMfrZqNgMGp6/w/HP6JyyCeftfbb6/I zXW0loUuHBocrXkbJ4ho3eH0LJ8N3LuqKoWZCqcN/58iPCA3V34GAjl06becZCjv VCCO/RN7LFf1f21omxevNLqNYuSQghnNOSnnvs9Auy6n/183Z55Dfts8w8TE2+LF kjahG1OvQIR87Ulc3LOfgwOVxJuiqffP/t0IiY5xkkhEC/5mhGIBzOH1zmCU91At T40cWKrIpP9uiVw4h8RD7NszVZGTCPpByoD6hv72SgV3VWUpZmjmu8JGbWCR9lUB LUXyJP+InnoQjkODrHA9ME+fCKmwOHQf8MRTFUGT7HD+Btuc3cksTIIcmAQlZT+f uszrCse6+tYnE2ShYkcl =nA89 -----END PGP SIGNATURE----- --ghzN8eJ9Qlbqn3iT-- --===============1337216456== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1337216456==--