Re: [PATCH 09/12] drm/edid: Move HDMI_IDENTIFIER to hdmi.h

Thierry Reding
2013-08-19T19:31:42Z

[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]

On Mon, Aug 19, 2013 at 02:49:50PM +0100, Damien Lespiau wrote:
> On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote:
> > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote:
> > [...]
> > > +#define HDMI_IDENTIFIER 0x000c03
> >
> > HDMI_IDENTIFIER sounds really generic. Perhaps HDMI_INFOFRAME_OUI_HDMI?
>
> This identifier is not infoframe specific, it's the IEEE OUI:
>
> http://standards.ieee.org/develop/regauth/oui/oui.txt
>
> would HDMI_IEEE_OUI suit you?

Yes, that sounds much better. Or perhaps IEEE_OUI_HDMI? From a quick
grep through the kernel code using the OUI as a prefix seems to be
slightly more common. If we ever end up adding a header to collect
OUIs it'd be useful to namespace them somehow.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]