From: Ben Widawsky <ben@bwidawsk.net>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] assembler: error for the wrong syntax of SEND instruction on GEN6+
Date: Thu, 15 Aug 2013 14:47:47 -0700 [thread overview]
Message-ID: <20130815214747.GB22301@bwidawsk.net> (raw)
In-Reply-To: <20130815110017.GB4490@strange.amr.corp.intel.com>
On Thu, Aug 15, 2013 at 12:00:17PM +0100, Damien Lespiau wrote:
> On Wed, Aug 14, 2013 at 02:21:16PM -0700, Ben Widawsky wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> >
> > predicate SEND execsize dst sendleadreg payload directsrcoperand instoptions
> > predicate SEND execsize dst sendleadreg payload imm32reg instoptions
> > predicate SEND execsize dst sendleadreg payload sndopr imm32reg instoptions
> > predicate SEND execsize dst sendleadreg payload exp directsrcoperand instoptions
> >
> > The above four syntaxes are only used on legacy platforms which support implied move
> > from payload to dst.
> >
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> >
> > Somehow this ended up in our internal IGT. Anyone have an issue with me
> > pushing it to igt proper?
>
> Maybe just a small rewording of "the syntax of send instruction" error
> message. Otherwise:
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
>
I forgot to reword... but I had meant to. Already pushed, feel free to
fix up. Sorry.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-08-15 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 21:21 [PATCH] assembler: error for the wrong syntax of SEND instruction on GEN6+ Ben Widawsky
2013-08-15 11:00 ` Damien Lespiau
2013-08-15 21:47 ` Ben Widawsky [this message]
2013-08-20 13:27 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815214747.GB22301@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox