From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] assembler: error for the wrong syntax of
 SEND instruction on GEN6+
Date: Thu, 15 Aug 2013 14:47:47 -0700
Message-ID: <20130815214747.GB22301@bwidawsk.net>
References: <1376515276-25541-1-git-send-email-benjamin.widawsky@intel.com>
	<20130815110017.GB4490@strange.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id 156E7E60A3
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 15 Aug 2013 14:47:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130815110017.GB4490@strange.amr.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Aug 15, 2013 at 12:00:17PM +0100, Damien Lespiau wrote:
> On Wed, Aug 14, 2013 at 02:21:16PM -0700, Ben Widawsky wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> > 
> >    predicate SEND execsize dst sendleadreg payload directsrcoperand instoptions
> >    predicate SEND execsize dst sendleadreg payload imm32reg instoptions
> >    predicate SEND execsize dst sendleadreg payload sndopr imm32reg instoptions
> >    predicate SEND execsize dst sendleadreg payload exp directsrcoperand instoptions
> > 
> > The above four syntaxes are only used on legacy platforms which support implied move
> > from payload to dst.
> > 
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> > 
> > Somehow this ended up in our internal IGT. Anyone have an issue with me
> > pushing it to igt proper?
> 
> Maybe just a small rewording of "the syntax of send instruction" error
> message. Otherwise:
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> 

I forgot to reword... but I had meant to. Already pushed, feel free to
fix up. Sorry.
-- 
Ben Widawsky, Intel Open Source Technology Center