From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Invalidate TLBs for the rings after a reset Date: Fri, 16 Aug 2013 14:17:20 +0200 Message-ID: <20130816121720.GI776@phenom.ffwll.local> References: <1375812074-2665-1-git-send-email-chris@chris-wilson.co.uk> <20130816073135.GA2819@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id A75CAE6B54 for ; Fri, 16 Aug 2013 05:17:13 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id d17so911150eek.14 for ; Fri, 16 Aug 2013 05:17:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130816073135.GA2819@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 16, 2013 at 08:31:35AM +0100, Chris Wilson wrote: > On Tue, Aug 06, 2013 at 07:01:14PM +0100, Chris Wilson wrote: > > After any "soft gfx reset" we must manually invalidate the TLBs > > associated with each ring. Empirically, it seems that a > > suspend/resume or D3-D0 cycle count as a "soft reset". The symptom is > > that the hardware would fail to note the new address for its status > > page, and so it would continue to write the shadow registers and > > breadcrumbs into the old physical address (now used by something > > completely different, scary). Whereas the driver would read the new > > status page and never see any progress, it would appear that the GPU > > hung immediately upon resume. > > > > Based on a patch by naresh kumar kachhi > > > > Reported-by: Thiago Macieira > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64725 > > Signed-off-by: Chris Wilson > > Thiago reports that early testing indicates success. > > Anyone fancy acking this and sending this onto to stable@? Picked up for -fixes, thanks for the patch. I'll let it hang there a bit though before forwarding, so I don't plan to update the -fixes pull request I've just recently sent out. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch