From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Ben Widawsky" <benjamin.widawsky@intel.com>,
"Intel GFX" <intel-gfx@lists.freedesktop.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Ben Widawsky" <ben@bwidawsk.net>
Subject: Re: [PATCH] [v2] drm/i915/vma: Correct use after free in eviction
Date: Sun, 18 Aug 2013 19:26:57 +0200 [thread overview]
Message-ID: <20130818172657.GJ776@phenom.ffwll.local> (raw)
In-Reply-To: <20130816223112.GA9822@nuc-i3427.alporthouse.com>
On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote:
> On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote:
> > The vma will [possibly] be destroyed during unbind in eviction.
> > Immediately after this, we try to delete the list entry.
> >
> > Chris and Ville did the debug on this before I woke up, I just get to
> > take credit for the fix :p
> >
> > v2: Missed the drm_object_unreference use after free (Ville)
> >
> > Reported-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Since the commit message lacks that crucial piece of information: How was
this discovered? I use that to tune my gut feeling for gauging the
-nightly test effectiveness ...
> Should have spotted this earlier :(
>
> Can I have a couple more lines of whitespace?
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-08-18 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 17:43 [PATCH] drm/i915/vma: Correct use after free in eviction Ben Widawsky
2013-08-16 20:29 ` [PATCH] [v2] " Ben Widawsky
2013-08-16 22:31 ` Chris Wilson
2013-08-18 17:26 ` Daniel Vetter [this message]
2013-08-18 22:35 ` Ben Widawsky
2013-08-19 6:39 ` Daniel Vetter
2013-08-19 8:49 ` Mika Kuoppala
2013-08-19 9:01 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130818172657.GJ776@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox