From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] [v2] drm/i915/vma: Correct use after free
 in eviction
Date: Sun, 18 Aug 2013 19:26:57 +0200
Message-ID: <20130818172657.GJ776@phenom.ffwll.local>
References: <1376675024-779-1-git-send-email-benjamin.widawsky@intel.com>
	<1376684973-14743-1-git-send-email-benjamin.widawsky@intel.com>
	<20130816223112.GA9822@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51])
	by gabe.freedesktop.org (Postfix) with ESMTP id 64484E5F69
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 18 Aug 2013 10:26:47 -0700 (PDT)
Received: by mail-ee0-f51.google.com with SMTP id c1so1746775eek.38
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 18 Aug 2013 10:26:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130816223112.GA9822@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <benjamin.widawsky@intel.com>, Intel GFX <intel-gfx@lists.freedesktop.org>, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Aug 16, 2013 at 11:31:12PM +0100, Chris Wilson wrote:
> On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote:
> > The vma will [possibly] be destroyed during unbind in eviction.
> > Immediately after this, we try to delete the list entry.
> > =

> > Chris and Ville did the debug on this before I woke up, I just get to
> > take credit for the fix :p
> > =

> > v2: Missed the drm_object_unreference use after free (Ville)
> > =

> > Reported-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Since the commit message lacks that crucial piece of information: How was
this discovered? I use that to tune my gut feeling for gauging the
-nightly test effectiveness ...

> Should have spotted this earlier :(
> =

> Can I have a couple more lines of whitespace?
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch