From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: make IVB FDI training match spec v2
Date: Mon, 19 Aug 2013 11:06:34 -0700 [thread overview]
Message-ID: <20130819110634.47b3abc8@jbarnes-desktop> (raw)
In-Reply-To: <20130818190959.GM776@phenom.ffwll.local>
On Sun, 18 Aug 2013 21:09:59 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Apr 08, 2013 at 05:50:07PM -0300, Paulo Zanoni wrote:
> > Hi
> >
> > 2013/3/28 Jesse Barnes <jbarnes@virtuousgeek.org>:
> > > The existing code was trying different vswing and preemphasis settings
> > > in the wrong place, and wasn't trying them enough. So add a loop to
> > > walk through them, properly disabling FDI TX and RX in between if a
> > > failure is detected.
> > >
> > > v2: remove unneeded reg writes, add delays around bit lock checks (Jesse)
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Apparently this patch can curb fdi link train fail on some machines:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=51983
>
> Althouhg there's still other fail going on. Can you pls update your patch
> to Paulo's review and resend?
Sent, hopefully Paulo can add his r-b in reply. Forgot to add the
reference above too, I guess you can do that when applying Paulo's r-b.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2013-08-19 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 18:43 [PATCH] drm/i915: make IVB FDI training match spec Jesse Barnes
2013-03-28 19:03 ` [PATCH] drm/i915: make IVB FDI training match spec v2 Jesse Barnes
2013-04-08 20:50 ` Paulo Zanoni
2013-08-18 19:09 ` Daniel Vetter
2013-08-19 18:06 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819110634.47b3abc8@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox