From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: make IVB FDI training match spec
 v2
Date: Mon, 19 Aug 2013 11:06:34 -0700
Message-ID: <20130819110634.47b3abc8@jbarnes-desktop>
References: <1364496184-3172-1-git-send-email-jbarnes@virtuousgeek.org>
	<1364497393-4796-1-git-send-email-jbarnes@virtuousgeek.org>
	<CA+gsUGS_fUeiOVsqsBR_nO_KTshpjEjd-Z7Wu2Q9Zu5DcX4tfg@mail.gmail.com>
	<20130818190959.GM776@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy7-pub.mail.unifiedlayer.com
	(oproxy7-pub.mail.unifiedlayer.com [67.222.55.9])
	by gabe.freedesktop.org (Postfix) with SMTP id E2532E75C5
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 19 Aug 2013 11:05:49 -0700 (PDT)
In-Reply-To: <20130818190959.GM776@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 18 Aug 2013 21:09:59 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Mon, Apr 08, 2013 at 05:50:07PM -0300, Paulo Zanoni wrote:
> > Hi
> > 
> > 2013/3/28 Jesse Barnes <jbarnes@virtuousgeek.org>:
> > > The existing code was trying different vswing and preemphasis settings
> > > in the wrong place, and wasn't trying them enough.  So add a loop to
> > > walk through them, properly disabling FDI TX and RX in between if a
> > > failure is detected.
> > >
> > > v2: remove unneeded reg writes, add delays around bit lock checks (Jesse)
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Apparently this patch can curb fdi link train fail on some machines:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=51983
> 
> Althouhg there's still other fail going on. Can you pls update your patch
> to Paulo's review and resend?

Sent, hopefully Paulo can add his r-b in reply.  Forgot to add the
reference above too, I guess you can do that when applying Paulo's r-b.

-- 
Jesse Barnes, Intel Open Source Technology Center