From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: Don't destroy the vma placeholder during execbuffer reservation
Date: Tue, 20 Aug 2013 15:19:05 +0200 [thread overview]
Message-ID: <20130820131905.GR776@phenom.ffwll.local> (raw)
In-Reply-To: <1376999800-10151-1-git-send-email-chris@chris-wilson.co.uk>
On Tue, Aug 20, 2013 at 12:56:40PM +0100, Chris Wilson wrote:
> The execbuffer handle and exec_link were moved from the object into the
> vma. As the vma may be unbound and destroyed whilst attempting to
> reserve the execbuffer objects (either through a forced unbind to fix up
> a misalignment or through an evict-everything call) we need to prevent
> the free of the i915_vma itself. Otherwise not only is the list of
> objects to reserve corrupt, but we continue to reference stale vma
> entries.
>
> Fixes kernel crash with i-g-t/gem_evict_everything
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Bugzilla; https://bugs.freedesktop.org/show_bug.cgi?id=68298
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ben Widawsky <ben@bwidawsk.net>
Yeah, I think this is about as simple&clear as it gets. vmas used by
execbuf simply have a bit a strange lifetime rule ... Queued for -next,
thanks for the patch. Merged quickly since I want to keep the bisect fail
window small, but I'll smash the test result from QA on top as soon as we
have it.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-08-20 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 11:56 [PATCH] drm/i915: Don't destroy the vma placeholder during execbuffer reservation Chris Wilson
2013-08-20 13:19 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820131905.GR776@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox