From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Don't destroy the vma placeholder during execbuffer reservation Date: Tue, 20 Aug 2013 15:19:05 +0200 Message-ID: <20130820131905.GR776@phenom.ffwll.local> References: <1376999800-10151-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 1358EE6F17 for ; Tue, 20 Aug 2013 06:18:54 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id c50so201613eek.32 for ; Tue, 20 Aug 2013 06:18:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376999800-10151-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 20, 2013 at 12:56:40PM +0100, Chris Wilson wrote: > The execbuffer handle and exec_link were moved from the object into the > vma. As the vma may be unbound and destroyed whilst attempting to > reserve the execbuffer objects (either through a forced unbind to fix up > a misalignment or through an evict-everything call) we need to prevent > the free of the i915_vma itself. Otherwise not only is the list of > objects to reserve corrupt, but we continue to reference stale vma > entries. > > Fixes kernel crash with i-g-t/gem_evict_everything > > Reported-by: Dan Carpenter > Bugzilla; https://bugs.freedesktop.org/show_bug.cgi?id=68298 > Signed-off-by: Chris Wilson > Cc: Ben Widawsky Yeah, I think this is about as simple&clear as it gets. vmas used by execbuf simply have a bit a strange lifetime rule ... Queued for -next, thanks for the patch. Merged quickly since I want to keep the bisect fail window small, but I'll smash the test result from QA on top as soon as we have it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch