From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 6/6] drm/i915: enable Package C8+ by default
Date: Thu, 22 Aug 2013 16:13:32 +0200 [thread overview]
Message-ID: <20130822141332.GN26909@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+vFmah+UwLhp0Ku0-y0Y4mJJDwkuEgM_mrP6rfBPTZs9g@mail.gmail.com>
On Wed, Aug 21, 2013 at 12:43:54PM -0300, Rodrigo Vivi wrote:
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
>
> On Mon, Aug 19, 2013 at 1:18 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > This should be working, so enable it by default. Also easy to revert.
> >
> > v2: Rebase, s/allow/enable/.
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Series merged to dinq with a small note for the first patch that the
discussion with hw guys is still ongoing.
-Daniel
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index ad28a72..735dd56 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -141,9 +141,9 @@ module_param_named(fastboot, i915_fastboot, bool, 0600);
> > MODULE_PARM_DESC(fastboot, "Try to skip unnecessary mode sets at boot time "
> > "(default: false)");
> >
> > -int i915_enable_pc8 __read_mostly = 0;
> > +int i915_enable_pc8 __read_mostly = 1;
> > module_param_named(enable_pc8, i915_enable_pc8, int, 0600);
> > -MODULE_PARM_DESC(enable_pc8, "Enable support for low power package C states (PC8+) (default: false)");
> > +MODULE_PARM_DESC(enable_pc8, "Enable support for low power package C states (PC8+) (default: true)");
> >
> > int i915_pc8_timeout __read_mostly = 5000;
> > module_param_named(pc8_timeout, i915_pc8_timeout, int, 0600);
> > --
> > 1.8.1.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-08-22 14:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 16:18 [PATCH 0/6] Final PC8+ patches Paulo Zanoni
2013-08-19 16:18 ` [PATCH 1/6] drm/i915: grab force_wake when restoring LCPLL Paulo Zanoni
2013-08-19 18:25 ` Chris Wilson
2013-08-19 19:01 ` Paulo Zanoni
2013-08-19 22:53 ` Ben Widawsky
2013-08-20 14:27 ` Paulo Zanoni
2013-08-19 16:18 ` [PATCH 2/6] drm/i915: fix SDEIMR assertion when disabling LCPLL Paulo Zanoni
2013-08-21 15:37 ` Rodrigo Vivi
2013-08-19 16:18 ` [PATCH 3/6] drm/i915: allow package C8+ states on Haswell (disabled) Paulo Zanoni
2013-08-19 18:29 ` Chris Wilson
2013-08-19 16:18 ` [PATCH 4/6] drm/i915: add i915_pc8_status debugfs file Paulo Zanoni
2013-08-21 15:42 ` Rodrigo Vivi
2013-08-19 16:18 ` [PATCH 5/6] drm/i915: add i915.pc8_timeout function Paulo Zanoni
2013-08-21 15:43 ` Rodrigo Vivi
2013-08-19 16:18 ` [PATCH 6/6] drm/i915: enable Package C8+ by default Paulo Zanoni
2013-08-21 15:43 ` Rodrigo Vivi
2013-08-22 14:13 ` Daniel Vetter [this message]
2013-08-19 16:20 ` [PATCH igt] tests: add pc8 Paulo Zanoni
2013-08-20 20:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822141332.GN26909@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox