From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Restore the preliminary HW check. Date: Fri, 23 Aug 2013 16:33:58 -0700 Message-ID: <20130823163358.00b0502e@jbarnes-desktop> References: <1377298807-24994-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9-pub.mail.unifiedlayer.com (oproxy9-pub.mail.unifiedlayer.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 5C8B2E5FF0 for ; Fri, 23 Aug 2013 16:33:13 -0700 (PDT) In-Reply-To: <1377298807-24994-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, 23 Aug 2013 16:00:07 -0700 Ben Widawsky wrote: > We still maintain code internally that cares about preliminary support. > Leaving the check here doesn't hurt anyone, and should keep things more > in line. > > This time around, stick the info in the intel_info structure, and also > change the error from DRM_ERROR->DRM_INFO. I hate this param. But this looks like a better way to do it than the ID list we had in pci_probe before. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center