From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing
 reg val
Date: Fri, 23 Aug 2013 22:10:49 +0200
Message-ID: <20130823201049.GW26909@phenom.ffwll.local>
References: <1377283657-20808-1-git-send-email-imre.deak@intel.com>
	<CA+gsUGQWhhP=6-7-0jVmAAxAeiXdX7g0hSOfct2qRUOM_bE2Tg@mail.gmail.com>
	<20130823200127.GV26909@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com
	[209.85.215.178])
	by gabe.freedesktop.org (Postfix) with ESMTP id DFFEEE6A4B
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 23 Aug 2013 13:10:38 -0700 (PDT)
Received: by mail-ea0-f178.google.com with SMTP id a15so481730eae.23
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 23 Aug 2013 13:10:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130823200127.GV26909@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Aug 23, 2013 at 10:01:27PM +0200, Daniel Vetter wrote:
> On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote:
> > 2013/8/23 Imre Deak <imre.deak@intel.com>:
> > > Fix the typo introduced in
> > >
> > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> > > Author: Keith Packard <keithp@keithp.com>
> > > Date:   Wed Nov 16 16:26:07 2011 -0800
> > >
> > >     drm/i915: Hook up Ivybridge eDP
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> > > Tested-by: Jeremy Moles <cubicool@gmail.com>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > 
> > Nice catch!
> > 
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Queued for -next, thanks for the patch.

Ok, dropped again since Paulo told me on irc that we fail link training
without this and so this is a black screen fix and so should go to -fixes
with cc: stable.

Grumpy maintainer note: Stuff like this _really_ must be part of the
commit message. A headline of "fix typo in ..." plus no mention of any
further impact than the fixed type for a black screen bug in the commit
message is seriously misleading.

Also this should imo be caught in review (since Paulo obviously knew
what's going on).

Please resend.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch