Re: [PATCH] drm/i915: ivb: fix typo in dp voltage swing reg val

Daniel Vetter
2013-08-23T20:10:38Z

On Fri, Aug 23, 2013 at 10:01:27PM +0200, Daniel Vetter wrote:
> On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote:
> > 2013/8/23 Imre Deak <imre.deak@intel.com>:
> > > Fix the typo introduced in
> > >
> > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85
> > > Author: Keith Packard <keithp@keithp.com>
> > > Date: Wed Nov 16 16:26:07 2011 -0800
> > >
> > > drm/i915: Hook up Ivybridge eDP
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880
> > > Tested-by: Jeremy Moles <cubicool@gmail.com>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> >
> > Nice catch!
> >
> > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Queued for -next, thanks for the patch.

Ok, dropped again since Paulo told me on irc that we fail link training
without this and so this is a black screen fix and so should go to -fixes
with cc: stable.

Grumpy maintainer note: Stuff like this _really_ must be part of the
commit message. A headline of "fix typo in ..." plus no mention of any
further impact than the fixed type for a black screen bug in the commit
message is seriously misleading.

Also this should imo be caught in review (since Paulo obviously knew
what's going on).

Please resend.

Thanks, Daniel