From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: sanitize forcewake registers on reset Date: Mon, 26 Aug 2013 09:37:23 +0200 Message-ID: <20130826073723.GC26909@phenom.ffwll.local> References: <1377265950-16006-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by gabe.freedesktop.org (Postfix) with ESMTP id D8D73E6F81 for ; Mon, 26 Aug 2013 00:37:12 -0700 (PDT) Received: by mail-ea0-f180.google.com with SMTP id h10so1388687eaj.25 for ; Mon, 26 Aug 2013 00:37:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1377265950-16006-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 23, 2013 at 04:52:30PM +0300, Mika Kuoppala wrote: > In reset we try to restore the forcewake state to > pre reset state, using forcewake_count. The reset > doesn't seem to clear the forcewake bits so we > get warn on forcewake ack register not clearing. > > Use same mechanism as intel_uncore_sanitize() does > when loading driver to reset the forcewake bits, right > after the chip has been reset. > > Reviewed-by: Chris Wilson > Signed-off-by: Mika Kuoppala Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch