public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes
Date: Tue, 27 Aug 2013 11:57:38 +0200	[thread overview]
Message-ID: <20130827095736.GA11453@ulmo> (raw)
In-Reply-To: <1376927945-26635-4-git-send-email-damien.lespiau@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]

On Mon, Aug 19, 2013 at 04:58:54PM +0100, Damien Lespiau wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
[...]
> +static int
> +do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
> +{
[...]
> +		u8 vic;
> +
> +		vic = db[9 + offset + i];
> +
> +		vic--; /* VICs start at 1 */

This could've all gone on a single line, perhaps with the comment on
top, like so:

		/* VICs start at 1 */
		u8 vic = db[9 + offset + i] - 1;

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2013-08-27  9:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 15:58 HDMI 4k support v4 Damien Lespiau
2013-08-19 15:58 ` [PATCH 01/14] drm: Don't export drm_find_cea_extension() any more Damien Lespiau
2013-08-19 15:58 ` [PATCH 02/14] drm/edid: Fix add_cea_modes() style issues Damien Lespiau
2013-08-19 15:58 ` [PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes Damien Lespiau
2013-08-27  9:57   ` Thierry Reding [this message]
2013-08-19 15:58 ` [PATCH 04/14] drm: Add support for alternate clocks of " Damien Lespiau
2013-08-19 15:58 ` [PATCH 05/14] video/hdmi: Don't let the user of this API create invalid infoframes Damien Lespiau
2013-08-19 15:58 ` [PATCH 06/14] video/hdmi: Derive the bar data valid bit from the bar data fields Damien Lespiau
2013-08-19 15:58 ` [PATCH 07/14] video/hdmi: Introduce helpers for the HDMI vendor specific infoframe Damien Lespiau
     [not found] ` <1376927945-26635-1-git-send-email-damien.lespiau-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-08-19 15:58   ` [PATCH 08/14] gpu: host1x: Port the HDMI vendor infoframe code the common helpers Damien Lespiau
2013-08-19 15:59 ` [PATCH 09/14] drm/edid: Move HDMI_IDENTIFIER to hdmi.h Damien Lespiau
2013-08-19 15:59 ` [PATCH 10/14] video/hdmi: Hook the HDMI vendor infoframe with the generic _pack() Damien Lespiau
2013-08-19 15:59 ` [PATCH 11/14] video/hdmi: Use hdmi_vendor_infoframe for the HDMI specific infoframe Damien Lespiau
2013-08-19 15:59 ` [PATCH 12/14] drm: Add a helper to forge HDMI vendor infoframes Damien Lespiau
2013-08-19 15:59 ` [PATCH 13/14] drm/i915/hdmi: Write HDMI vendor specific infoframes Damien Lespiau
2013-08-19 15:59 ` [PATCH 14/14] video/hdmi: Rename HDMI_IDENTIFIER to HDMI_IEEE_OUI Damien Lespiau
2013-08-27 10:14 ` HDMI 4k support v4 Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827095736.GA11453@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=damien.lespiau@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox