From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes Date: Tue, 27 Aug 2013 11:57:38 +0200 Message-ID: <20130827095736.GA11453@ulmo> References: <1376927945-26635-1-git-send-email-damien.lespiau@intel.com> <1376927945-26635-4-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1487287735==" Return-path: In-Reply-To: <1376927945-26635-4-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1487287735== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Content-Disposition: inline --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 19, 2013 at 04:58:54PM +0100, Damien Lespiau wrote: [...] > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c [...] > +static int > +do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len) > +{ [...] > + u8 vic; > + > + vic = db[9 + offset + i]; > + > + vic--; /* VICs start at 1 */ This could've all gone on a single line, perhaps with the comment on top, like so: /* VICs start at 1 */ u8 vic = db[9 + offset + i] - 1; Thierry --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iQIcBAEBAgAGBQJSHHgQAAoJEN0jrNd/PrOhnosP/iqu4qh6Z8iXC2GpF9i3j26G HIS+pchpqc8Nr/zB8+TKsNoeHZvJDTT0uy56i9wLYJYbfdC5LpF/gT1SXcJRIZ+n WxnZivdfsM6sgbXOZmCTlqlMUZg7X38Jt+j/LYydN8PfULtpD+Og0o6cA9T8YKHv eYsWqMnNCIDgq9Ydq3iz/+GJgyLGsWzEzN9+5uwnk9oqQIdlXOYt+NaGl/KIwHqj MEULbaqLUhxUaaltc7+yeGarFRRUvk851QQAA3mHmys1jxIFVEU7kAtcZJed4eXj sSoDIeSgXColVPFk54HmALt4ViIE9cKtQp3OPhb/pKEGOYlNmDa//cwf9Uuisdo1 EanaAKCQ47yxlC5kWe6turfa0o6D++a3mNQEmp516ZzZ7bqYuojBSQxKkaS4CGid sVQQl0zT8ocGWxhntOFlKdDXfZd1taW5brhy9QVKT1afxKCCTJZZXJmV89FQjNM/ lE+GALb0oOsTz4WegjL2vvDENxq5p8V8UX5KyPrFpcyHqCY6vX58yROwjWDZ5B8q uOt4RDr4azOHm6zI4CDrgtXM+gAtXRSppHY+wI8byqx8cnQ2s3yIKOTpbYGTFhT3 Ug+c1fk95iiMYCehfkP9PQ3HKP50LVnnA148/rPwSz+Ohlg0twEP/mcXjkQlfaBq SK2phjOa5lp2ZzhWCI0L =pkWK -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e-- --===============1487287735== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1487287735==--