Re: [PATCH 03/14] drm/edid: Parse the HDMI CEA block and look for 4k modes

Thierry Reding
2013-08-27T09:57:38Z

[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]

On Mon, Aug 19, 2013 at 04:58:54PM +0100, Damien Lespiau wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
[...]
> +static int
> +do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
> +{
[...]
> + u8 vic;
> +
> + vic = db[9 + offset + i];
> +
> + vic--; /* VICs start at 1 */

This could've all gone on a single line, perhaps with the comment on
top, like so:

/* VICs start at 1 */
u8 vic = db[9 + offset + i] - 1;

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]