From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Report enabled slices on Haswell GT3 Date: Thu, 29 Aug 2013 09:09:32 +0200 Message-ID: <20130829070931.GC5606@phenom.ffwll.local> References: <1377719146-4337-1-git-send-email-rodrigo.vivi@gmail.com> <20130828210940.GB4726@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 145FBE5DFD for ; Thu, 29 Aug 2013 00:09:21 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id b45so27207eek.15 for ; Thu, 29 Aug 2013 00:09:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130828210940.GB4726@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 28, 2013 at 10:09:40PM +0100, Chris Wilson wrote: > On Wed, Aug 28, 2013 at 04:45:46PM -0300, Rodrigo Vivi wrote: > > Batchbuffers constructed by userspace can conditionalise their URB > > allocations through the use of the MI_SET_PREDICATE command. This > > command can read the MI_PREDICATE_RESULT_2 register to see how many > > slices are enabled on GT3, and by virtue of the result, scale their > > memory allocations to fit enabled memory. > > > > Of course, this only works if the kernel sets the appropriate bit in the > > register first. > > > > v2: Better commit subject and message by Chris Wilson. > > > > Cc: Chris Wilson > > Credits-by: Yejun Guo > > Signed-off-by: Rodrigo Vivi > > I would have written the I915_WRITE() differently but, > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch