From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Restore the preliminary HW check. Date: Thu, 29 Aug 2013 09:35:14 -0700 Message-ID: <20130829163513.GB4234@bwidawsk.net> References: <1377298807-24994-1-git-send-email-benjamin.widawsky@intel.com> <20130823163358.00b0502e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id B4189E77D6 for ; Thu, 29 Aug 2013 09:35:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130823163358.00b0502e@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 23, 2013 at 04:33:58PM -0700, Jesse Barnes wrote: > On Fri, 23 Aug 2013 16:00:07 -0700 > Ben Widawsky wrote: > > > We still maintain code internally that cares about preliminary support. > > Leaving the check here doesn't hurt anyone, and should keep things more > > in line. > > > > This time around, stick the info in the intel_info structure, and also > > change the error from DRM_ERROR->DRM_INFO. > > I hate this param. > > But this looks like a better way to do it than the ID list we had in > pci_probe before. > > Reviewed-by: Jesse Barnes > Daniel, ping. One of my goals is to allow people to easily look at source and determine which HW is preliminary, and which isn't. -- Ben Widawsky, Intel Open Source Technology Center