From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Restore the preliminary HW check.
Date: Thu, 29 Aug 2013 21:13:52 +0200
Message-ID: <20130829191352.GG5606@phenom.ffwll.local>
References: <1377298807-24994-1-git-send-email-benjamin.widawsky@intel.com>
	<20130823163358.00b0502e@jbarnes-desktop>
	<20130829163513.GB4234@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com
	[209.85.215.175])
	by gabe.freedesktop.org (Postfix) with ESMTP id 511B0E79AE
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 29 Aug 2013 12:13:42 -0700 (PDT)
Received: by mail-ea0-f175.google.com with SMTP id m14so450894eaj.34
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 29 Aug 2013 12:13:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130829163513.GB4234@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Aug 29, 2013 at 09:35:14AM -0700, Ben Widawsky wrote:
> On Fri, Aug 23, 2013 at 04:33:58PM -0700, Jesse Barnes wrote:
> > On Fri, 23 Aug 2013 16:00:07 -0700
> > Ben Widawsky <benjamin.widawsky@intel.com> wrote:
> > 
> > > We still maintain code internally that cares about preliminary support.
> > > Leaving the check here doesn't hurt anyone, and should keep things more
> > > in line.
> > > 
> > > This time around, stick the info in the intel_info structure, and also
> > > change the error from DRM_ERROR->DRM_INFO.
> > 
> > I hate this param.
> > 
> > But this looks like a better way to do it than the ID list we had in
> > pci_probe before.

We've never had a table of pci ids, but a simple check for IS_HASWELL ...

> > 
> > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> 
> Daniel, ping. One of my goals is to allow people to easily look at
> source and determine which HW is preliminary, and which isn't.

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch