From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 01/19] drm/i915: Pass crtc to
 intel_update_watermarks()
Date: Fri, 30 Aug 2013 23:29:58 +0300
Message-ID: <20130830202958.GP11428@intel.com>
References: <1377862239-17052-1-git-send-email-ville.syrjala@linux.intel.com>
	<1377862239-17052-2-git-send-email-ville.syrjala@linux.intel.com>
	<CA+gsUGTUH6BaJC180jS_T7gg82tOe6=oQuye96GZGXgs7eGYkQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6EF4AE5C0A
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 30 Aug 2013 13:30:01 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTUH6BaJC180jS_T7gg82tOe6=oQuye96GZGXgs7eGYkQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Aug 30, 2013 at 05:09:49PM -0300, Paulo Zanoni wrote:
> 2013/8/30  <ville.syrjala@linux.intel.com>:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > Passing the appropriate crtc to intel_update_watermarks() should help
> > in avoiding needless work in the future.
> >
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> I like the fact that now we're passing the CRTC, but <bikeshed> my
> only worry is that now some functions overwrite the "crtc" we pass as
> argument, so this might be confusing and maybe lead to bugs in the
> future: perhaps the argument could be called unused_crtc or
> ignored_crtc, then we'd keep the "crtc" variables they already have
> </bikeshed>. But it's just a bikeshed, so with or without changes:
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>.

Right. It could be a bit confusing. I'll change it.

-- =

Ville Syrj=E4l=E4
Intel OTC