From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering
Date: Fri, 30 Aug 2013 20:39:46 -0700 [thread overview]
Message-ID: <20130831033946.GA1088@bwidawsk.net> (raw)
In-Reply-To: <20130830235030.GP4726@nuc-i3427.alporthouse.com>
On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote:
> On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote:
> > lifted from Daniel:
> > pread/pwrite isn't about the object's domain at all, but purely about
> > synchronizing for outstanding rendering. Replacing the call to
> > set_to_gtt_domain with a wait_rendering would imo improve code
> > readability. Furthermore we could pimp pread to only block for
> > outstanding writes and not for reads.
> >
> > Since you're not the first one to trip over this: Can I volunteer you
> > for a follow-up patch to fix this?
> >
> > Recommended-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> This should fail i-g-t...
> -Chris
>
Daniel, how have I failed your plan?
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-08-31 3:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 23:43 [PATCH 0/8] [RESEND] VMA patches Ben Widawsky
2013-08-30 23:43 ` [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering Ben Widawsky
2013-08-30 23:50 ` Chris Wilson
2013-08-31 3:39 ` Ben Widawsky [this message]
2013-09-02 6:32 ` Daniel Vetter
2013-09-02 13:14 ` Chris Wilson
2013-09-02 14:12 ` Daniel Vetter
2013-09-03 16:08 ` Daniel Vetter
2013-09-03 23:53 ` Ben Widawsky
2013-08-30 23:43 ` [PATCH 2/8] drm/i915: Extract vm specific part of eviction Ben Widawsky
2013-08-30 23:52 ` Chris Wilson
2013-08-31 3:39 ` Ben Widawsky
2013-08-30 23:43 ` [PATCH 3/8] drm/i915: evict VM instead of everything Ben Widawsky
2013-08-31 0:04 ` Chris Wilson
2013-08-30 23:43 ` [PATCH 4/8] drm/i915: trace vm eviction " Ben Widawsky
2013-08-31 0:06 ` Chris Wilson
2013-08-31 3:40 ` Ben Widawsky
2013-08-30 23:43 ` [PATCH 5/8] drm/i915: Convert active API to VMA Ben Widawsky
2013-08-31 0:08 ` Chris Wilson
2013-08-30 23:43 ` [PATCH 6/8] drm/i915: Add bind/unbind object functions to VM Ben Widawsky
2013-08-31 0:12 ` Chris Wilson
2013-08-31 3:40 ` Ben Widawsky
2013-09-03 14:48 ` Chris Wilson
2013-09-02 12:46 ` Ville Syrjälä
2013-09-04 0:20 ` Ben Widawsky
2013-09-04 7:31 ` Ville Syrjälä
2013-08-30 23:44 ` [PATCH 7/8] drm/i915: Use the new vm [un]bind functions Ben Widawsky
2013-08-30 23:44 ` [PATCH 8/8] drm/i915: eliminate vm->insert_entries() Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2013-09-11 21:57 [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130831033946.GA1088@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox