From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 03/12] drm/i915: Use adjusted_mode in HDMI
 12bpc clock check
Date: Tue, 3 Sep 2013 09:50:07 +0200
Message-ID: <20130903075007.GA5767@phenom.ffwll.local>
References: <1378145619-22655-1-git-send-email-ville.syrjala@linux.intel.com>
	<1378145619-22655-4-git-send-email-ville.syrjala@linux.intel.com>
	<20130902183945.GB9374@phenom.ffwll.local>
	<20130902190526.GX11428@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f174.google.com (mail-ea0-f174.google.com
	[209.85.215.174])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6714AE5C5B
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  3 Sep 2013 00:49:57 -0700 (PDT)
Received: by mail-ea0-f174.google.com with SMTP id z15so2777823ead.19
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 03 Sep 2013 00:49:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130902190526.GX11428@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Sep 02, 2013 at 10:05:26PM +0300, Ville Syrj=E4l=E4 wrote:
> On Mon, Sep 02, 2013 at 08:39:45PM +0200, Daniel Vetter wrote:
> > On Mon, Sep 02, 2013 at 09:13:30PM +0300, ville.syrjala@linux.intel.com=
 wrote:
> > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > The pixel clock should come from adjusted_mode not requested_mode.
> > > In this case the two should be the same as we don't currently
> > > overwrite the clock in the case of HDMI. But let's make the code
> > > safe against such things happening in the future.
> > > =

> > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Atm only the encoder overrides the adjusted_mode at all, so I think I
> > prefer the current code flow as clearer ...
> =

> And I'd atually prefer to kill requested_mode. It's confusing.
> =

> Only hdisplay/vdisplay are always valid. Well even that's not true
> as can be seen from my double wide series.
> =

> The clock and timings can be trusted only at the very beginning of the
> compute config step. And at that point adjusted_mode contains the exact
> same information. Also apart from the clock, we never use the other
> timings from requested_mode, so keeping the whole thing around seems
> more or less pointless.

Ok, count me slightly convinced. I agree that after the pipe config
compute stage the only thing we can rely on is h/vdisplay (it's also the
only thing we actually cross-check). So I guess ditching
config->requested_mode is a good goal. If you throw a patch on top to add
a bit of documentation for the adjusted_mode and the pipe_src_h|w fields
I'll even be happy ;-)

Cheers, Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch