From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 11/12] drm/i915: Add explicit pipe src size
 to pipe config
Date: Tue, 3 Sep 2013 12:32:23 +0300
Message-ID: <20130903093223.GD11428@intel.com>
References: <1378145619-22655-1-git-send-email-ville.syrjala@linux.intel.com>
	<1378145619-22655-12-git-send-email-ville.syrjala@linux.intel.com>
	<20130902184619.GE9374@phenom.ffwll.local>
	<20130902191143.GY11428@intel.com>
	<20130903075240.GB5767@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id D8DE3E696E
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  3 Sep 2013 02:32:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130903075240.GB5767@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 03, 2013 at 09:52:40AM +0200, Daniel Vetter wrote:
> On Mon, Sep 02, 2013 at 10:11:43PM +0300, Ville Syrj=E4l=E4 wrote:
> > On Mon, Sep 02, 2013 at 08:46:19PM +0200, Daniel Vetter wrote:
> > > On Mon, Sep 02, 2013 at 09:13:38PM +0300, ville.syrjala@linux.intel.c=
om wrote:
> > > > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > > =

> > > > Rather that mess about with hdisplay/vdisplay from requested_mode, =
add
> > > > explicit pipe src size information to pipe config.
> > > > =

> > > > Now requested_mode is only really relevant for dvo/sdvo output timi=
ngs.
> > > > For everything else either adjusted_mode or pipe src size should be
> > > > used.
> > > > =

> > > > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > > =

> > > Not sold on this - imo it makes more sense to keep track of this in a=
 new
> > > plane config structure or something similar which ties the fb + metad=
ata
> > > to the crtc. Then we could move a bunch of things we currently have i=
n the
> > > pipe config or someplaces else even (fbc, ips, ...) over there.
> > =

> > This size isn't the plane size. It's the pipe size. Two different thing=
s.
> =

> Oops, I guess I'm confused about this. In that case this makes tons of
> sense. Now just one of our residential watermarks experts (definitely not
> me) needs to double-check that we're always using the right thing ...

Actually we're now using pipe_src_{w,h} always. I was considering adding
primary_{w,h} to pipe config already, but then decided that I could wait
until we split the primary from the crtc.

The reason I need to use pipe_src_{w,h} is the pipe_src_w roudning for
double wide & co. We need to clip the primary to the pipe dimensions, so
the same value works as long as primary planes are fullscreen only.

But if you'd prefer I could still add the explicit primary dimensions
to pipe config.

-- =

Ville Syrj=E4l=E4
Intel OTC