From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Sandeep Ramankutty <sandeepx.ramakutty@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] [VPG HSW-A] drm/i915: BUN vol4g[DevHSW] Vblank interrupt on disabled pipe
Date: Wed, 4 Sep 2013 15:45:46 +0300 [thread overview]
Message-ID: <20130904124546.GR11428@intel.com> (raw)
In-Reply-To: <1378295042-12408-1-git-send-email-sandeepx.ramakutty@intel.com>
On Wed, Sep 04, 2013 at 05:14:02PM +0530, Sandeep Ramankutty wrote:
> This change is to comply with the BUN - Vblank interrupt on disabled pipe.
> BUN states - Do not unmask and enable a vertical blank interrupt on a pipe
> that is not enabled. Do not leave this interrupt enabled and unmasked after
> the associated pipe is disabled. If the vblank interrupt is unmasked and
> enabled on a disabled pipe it will block package C3, wasting power.
We mask the interrupt in IMR when we don't need it, but we do leave it
enabled in IER. Is that a problem on HSW? I'm guessing not, since
powertop is telling me that I'm currently reaching pc8 w/ displays off,
and pc7 w/ eDP on.
In any case the patch would be buggy since it has no locking around
DEIER RMW accesses. But since powertop is telling me everything is
already fine, we shouldn't need this patch anyway.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-04 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 11:44 [PATCH] [VPG HSW-A] drm/i915: BUN vol4g[DevHSW] Vblank interrupt on disabled pipe Sandeep Ramankutty
2013-09-04 11:56 ` Chris Wilson
2013-09-04 12:45 ` Ville Syrjälä [this message]
2013-11-07 11:56 ` Ramakutty, SandeepX
2013-11-07 12:52 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904124546.GR11428@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sandeepx.ramakutty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox