Re: [PULL] drm-intel-fixes

Daniel Vetter
2014-08-09T08:44:24Z

On Sat, Aug 9, 2014 at 12:07 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Aug 8, 2014 at 1:52 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> Got this while bisecting. I'm not sure it's related
>
> It's not.

Iirc it was an intermediate merge issue between two patch series. If
you still see this on your tip, please scream. The warning is just one
of our modeset sequence asserts firing.

> The actual bug was panel self refresh. It's still broken, and doesn't
> work. So enabling it by default was a big mistake (commit
> b6d547791fd3: "drm/i915: Enable PSR by default.")
>
> I've reverted that commit, you guys can try again with PSR for the
> next kernel release if somebody figures out how to get the damn thing
> *out* of panel self-refresh (because that's what I'm assuming is going
> on: the graphics may still work fine, but nothing updates on the panel
> any more).

A bit surprising since the only psr issue I was aware of was that we
failed to entire psr (and that is likely a fumble in the tracking of
cursor updates). Otoh PSR isn't enabled on baytrail because it's
hang-happy there and the testcase we have for all the corner-cases in
psr tracking turned out to be completely broken and no on fixed this
yet. Anyway thanks for digging this up and pushing the revert
yesterday - I was already in w/e mode ;-)

Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch