Re: [PATCH v2 01/14] drm/i915: Grab the pixel clock from adjusted_mode not requested_mode

Damien Lespiau
2013-09-10T14:27:39Z

On Wed, Sep 04, 2013 at 06:25:18PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> i9xx_set_pipeconf() attempts to get the current pixel clock from
> requested_mode. requested_mode.clock may be totally bogus, so the
> clock should come from adjusted_mode.
>
> v2: Dropped the intel_compute_config() hunk due to killing of the
> INTEL_FDI_FREQ check
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

If you feel brave enough you could also have reindent the comment above
the modified line to 80 chars.

--
Damien

> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a4fe594..2c450fe 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4786,7 +4786,7 @@ static void i9xx_set_pipeconf(struct intel_crtc *intel_crtc)
> * XXX: No double-wide on 915GM pipe B. Is that the only reason for the
> * pipe == 0 check?
> */
> - if (intel_crtc->config.requested_mode.clock >
> + if (intel_crtc->config.adjusted_mode.clock >
> dev_priv->display.get_display_clock_speed(dev) * 9 / 10)
> pipeconf |= PIPECONF_DOUBLE_WIDE;
> }
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx