From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT Date: Thu, 12 Sep 2013 13:52:36 -0700 Message-ID: <20130912135236.593fa73d@jbarnes-desktop> References: <1378932200-1877-1-git-send-email-jbarnes@virtuousgeek.org> <20130912203841.GC5459@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by gabe.freedesktop.org (Postfix) with SMTP id DE19EE7D21 for ; Thu, 12 Sep 2013 13:51:14 -0700 (PDT) In-Reply-To: <20130912203841.GC5459@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 Sep 2013 22:38:41 +0200 Daniel Vetter wrote: > On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote: > > Unsupported; we just do RC6. > > > > Signed-off-by: Jesse Barnes > > You only change the sysfs stuff here, so I wondered where the hunk for > intel_pm.c is. And noticed that we don't actually obey the enable_rc6 > parameter! Aside: We don't do any such force-to-0 stuff on other > platforms, so why do we need this? Gosh all these questions for such a simple patch. I was just annoyed that the sysfs rc6 residency test was getting bogus values from registers that happened to be there but don't correlate with rc6. -- Jesse Barnes, Intel Open Source Technology Center