From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: do not update cursor in crtc mode set
Date: Fri, 13 Sep 2013 10:30:17 +0300 [thread overview]
Message-ID: <20130913073017.GG20128@intel.com> (raw)
In-Reply-To: <20130912200905.GB14235@nuc-i3427.alporthouse.com>
On Thu, Sep 12, 2013 at 09:09:05PM +0100, Chris Wilson wrote:
> On Thu, Sep 12, 2013 at 10:45:41PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Jani Nikula <jani.nikula@intel.com>
> >
> > The cursor is disabled before crtc mode set in crtc disable (and we
> > assert this is the case), and enabled afterwards in crtc enable. Do not
> > update it in crtc mode set.
> >
> > On HSW enabling a plane on a disabled pipe may hang the entire system.
> > And there's no good reason for doing it ever, so just don't.
> >
> > v2: Add note about HSW hangs - vsyrjala
> >
> > Cc: stable@vger.kernel.org
> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Where did the asserts go? :)
I asked Jani to move them around a bit, which AFAIK he didn't yet. So
I figured we'd just go with a minimal fix for stable first and then
slap on more asserts later in dinq.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-13 7:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 19:45 [PATCH 0/3] drm/i915: HSW modeset hang fix ville.syrjala
2013-09-12 19:45 ` [PATCH 1/3] drm/i915: do not update cursor in crtc mode set ville.syrjala
2013-09-12 20:09 ` Chris Wilson
2013-09-13 7:30 ` Ville Syrjälä [this message]
2013-09-13 8:03 ` [PATCH 1/2] drm/i915: add asserts for cursor disabled Jani Nikula
2013-09-13 8:03 ` [PATCH 2/2] drm/i915: clean up and simplify i9xx_crtc_mode_set wrt PLL handling Jani Nikula
2013-09-13 13:00 ` Daniel Vetter
2013-09-13 13:38 ` Jani Nikula
2013-09-13 14:07 ` Daniel Vetter
2013-09-13 14:47 ` Ville Syrjälä
2013-09-13 8:48 ` [PATCH 1/2] drm/i915: add asserts for cursor disabled Chris Wilson
2013-09-13 11:57 ` Ville Syrjälä
2013-09-13 12:59 ` Daniel Vetter
2013-09-12 19:45 ` [PATCH 2/3] drm/i915: Don't enable the cursor on a disable pipe ville.syrjala
2013-09-12 20:08 ` Chris Wilson
2013-09-13 7:28 ` [Intel-gfx] " Ville Syrjälä
2013-09-12 19:45 ` [PATCH 3/3] drm/i915: Don't enable sprites on a disabled pipe ville.syrjala
2013-09-12 20:13 ` [Intel-gfx] " Chris Wilson
2013-09-13 7:40 ` Ville Syrjälä
2013-09-13 7:50 ` Ville Syrjälä
2013-09-13 7:54 ` Ville Syrjälä
2013-09-13 8:43 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913073017.GG20128@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox