From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: do not update cursor in crtc mode set Date: Fri, 13 Sep 2013 10:30:17 +0300 Message-ID: <20130913073017.GG20128@intel.com> References: <1379015143-13822-1-git-send-email-ville.syrjala@linux.intel.com> <1379015143-13822-2-git-send-email-ville.syrjala@linux.intel.com> <20130912200905.GB14235@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20130912200905.GB14235@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 12, 2013 at 09:09:05PM +0100, Chris Wilson wrote: > On Thu, Sep 12, 2013 at 10:45:41PM +0300, ville.syrjala@linux.intel.c= om wrote: > > From: Jani Nikula > >=20 > > The cursor is disabled before crtc mode set in crtc disable (and we > > assert this is the case), and enabled afterwards in crtc enable. Do= not > > update it in crtc mode set. > >=20 > > On HSW enabling a plane on a disabled pipe may hang the entire syst= em. > > And there's no good reason for doing it ever, so just don't. > >=20 > > v2: Add note about HSW hangs - vsyrjala > >=20 > > Cc: stable@vger.kernel.org > > Suggested-by: Ville Syrj=E4l=E4 > > Reviewed-by: Ville Syrj=E4l=E4 > > Signed-off-by: Jani Nikula >=20 > Where did the asserts go? :) I asked Jani to move them around a bit, which AFAIK he didn't yet. So I figured we'd just go with a minimal fix for stable first and then slap on more asserts later in dinq. --=20 Ville Syrj=E4l=E4 Intel OTC