Re: [PATCH 1/2] drm/i915: add asserts for cursor disabled

Chris Wilson
2013-09-13T08:48:38Z

On Fri, Sep 13, 2013 at 11:03:08AM +0300, Jani Nikula wrote:
> The cursor is supposed to be disabled during crtc mode set (disabled by
> ctrc disable). Assert this is the case.
>
> v2: move cursor disabled assert next to plane asserts (Ville)
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Lgtm. There's one extra place for paranoia that I spotted, in
*_update_cursor() we can assert that the cursor in the expected
visibility when we enter the function. That might be overkill for such a
frequently called operation, so just limiting it to the change in
visibility should be paranoid enough.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre