Re: [Intel-gfx] [PATCH 1/3] drm/i915: do not update cursor in crtc mode set

Ville Syrjälä
2013-09-13T07:30:17Z

On Thu, Sep 12, 2013 at 09:09:05PM +0100, Chris Wilson wrote:
> On Thu, Sep 12, 2013 at 10:45:41PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Jani Nikula <jani.nikula@intel.com>
> >
> > The cursor is disabled before crtc mode set in crtc disable (and we
> > assert this is the case), and enabled afterwards in crtc enable. Do not
> > update it in crtc mode set.
> >
> > On HSW enabling a plane on a disabled pipe may hang the entire system.
> > And there's no good reason for doing it ever, so just don't.
> >
> > v2: Add note about HSW hangs - vsyrjala
> >
> > Cc: stable@vger.kernel.org
> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Where did the asserts go? :)

I asked Jani to move them around a bit, which AFAIK he didn't yet. So
I figured we'd just go with a minimal fix for stable first and then
slap on more asserts later in dinq.

--
Ville Syrjälä
Intel OTC