Re: [PATCH 1/3] drm/i915: do not update cursor in crtc mode set

Chris Wilson
2013-09-12T20:09:09Z

On Thu, Sep 12, 2013 at 10:45:41PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Jani Nikula <jani.nikula@intel.com>
>
> The cursor is disabled before crtc mode set in crtc disable (and we
> assert this is the case), and enabled afterwards in crtc enable. Do not
> update it in crtc mode set.
>
> On HSW enabling a plane on a disabled pipe may hang the entire system.
> And there's no good reason for doing it ever, so just don't.
>
> v2: Add note about HSW hangs - vsyrjala
>
> Cc: stable@vger.kernel.org
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Where did the asserts go? :)
-Chris

--
Chris Wilson, Intel Open Source Technology Centre