From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/i915: don't save/restore LBB on Gen5+ Date: Fri, 13 Sep 2013 11:41:10 +0200 Message-ID: <20130913094110.GH5459@phenom.ffwll.local> References: <1379005101-1500-1-git-send-email-przanoni@gmail.com> <20130912173618.GD20128@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTP id B4049E7CB5 for ; Fri, 13 Sep 2013 02:40:56 -0700 (PDT) Received: by mail-ea0-f172.google.com with SMTP id r16so459415ead.3 for ; Fri, 13 Sep 2013 02:40:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130912173618.GD20128@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 12, 2013 at 08:36:18PM +0300, Ville Syrj=E4l=E4 wrote: > On Thu, Sep 12, 2013 at 01:58:17PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > = > > Because this PCI config register doesn't exist on Gen5+. > > = > > Signed-off-by: Paulo Zanoni > = > Yep. Can't see it in configdb. Actually it's only listed there for CTG > and CLN, which I guess makes sense as non-mobile platforms probably > don't have backlights. For BLB and ELK it's listed as reserved and RO, > so I guess it doesn't hurt to poke it on them. If I'm wrong we could > probably slap on an IS_MOBILE() check there too. Older stuff doesn't > exist in configdb, so that's as far back as I can go. > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch