Re: [PATCH 05/12] drm/edid: Expose mandatory stereo modes for HDMI sinks

Damien Lespiau
2013-09-16T21:28:30Z

On Mon, Sep 16, 2013 at 09:29:31PM +0300, Ville Syrjälä wrote:
> > static int
> > do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
> > @@ -2582,10 +2662,15 @@ do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
> >
> > /* the declared length is not long enough for the 2 first bytes
> > * of additional video format capabilities */
> > - offset += 2;
> > - if (len < (8 + offset))
> > + if (len < (8 + offset + 2))
> > goto out;
> >
> > + /* 3D_Present */
> > + offset++;
> > + if (db[8 + offset] & (1 << 7))
> > + modes += add_hdmi_mandatory_stereo_modes(connector);
>
> Hmm. I was thinking this is a bit soon since we haven't added the 4k
> modes, nor the alternate clock modes yet. But I guess the 4k modes
> aren't relevant here, and the alternate modes vs. 3D modes steps can
> be done in either order. Or did I miss something here?

You're not missing anything. It's indeed fine to add the mandatory modes
before the 4k ones because the mandatory modes are either 1080p, 1080i
or 720p. As for alternate clocks, I opted to re-use the current code
with one tiny adjustement, so the alternate clocks logic stays in one
place.

--
Damien