From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 14/14] drm/i915: Fix cursor visibility checks also for the right/bottom screen edges Date: Tue, 17 Sep 2013 12:56:27 +0300 Message-ID: <20130917095627.GS4531@intel.com> References: <1378308331-21388-1-git-send-email-ville.syrjala@linux.intel.com> <1378308331-21388-15-git-send-email-ville.syrjala@linux.intel.com> <20130916215217.GH32145@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D16CE6E07 for ; Tue, 17 Sep 2013 02:56:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130916215217.GH32145@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Sep 16, 2013 at 11:52:17PM +0200, Daniel Vetter wrote: > On Wed, Sep 04, 2013 at 06:25:31PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > First of all we should not be looking at fb->{width,height} as those do > > not tell us what the actual pipe size is. Second of all we need to use > > >=3D for the comparison. > > = > > So fix the comparison, and make use of the new pipe_src_{w,h} to > > determine the real pipe source dimensions. > > = > > Reviewed-by: Chris Wilson > > Signed-off-by: Ville Syrj=E4l=E4 > = > Merged the entire series to dinq, thanks for patches&review. I've also > made a small note that we should have an igt testcase for these cursor > corner-cases somewhere ... Which reminds me that I started to write one. Need to finish it up... -- = Ville Syrj=E4l=E4 Intel OTC