From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: only report hpd connector status change when it actually changed Date: Tue, 17 Sep 2013 17:27:24 +0200 Message-ID: <20130917152724.GP32145@phenom.ffwll.local> References: <1379417195-18097-1-git-send-email-jani.nikula@intel.com> <20130917143602.GN32145@phenom.ffwll.local> <87vc1zlcon.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id DD1A9E73F8 for ; Tue, 17 Sep 2013 08:27:09 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id d41so2817579eek.36 for ; Tue, 17 Sep 2013 08:27:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87vc1zlcon.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 17, 2013 at 05:56:08PM +0300, Jani Nikula wrote: > On Tue, 17 Sep 2013, Daniel Vetter wrote: > > On Tue, Sep 17, 2013 at 02:26:34PM +0300, Jani Nikula wrote: > >> This reduces dmesg noise when there's a glitch on the hpd line, or there > >> are more than one connectors on the same hpd line and only one of them > >> changes. > >> > >> While at it, switch to use the friendly status names instead of numbers. > >> > >> Signed-off-by: Jani Nikula > >> --- > >> drivers/gpu/drm/i915/i915_irq.c | 14 ++++++++++---- > >> 1 file changed, 10 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > >> index 13d26cf..a42f30b 100644 > >> --- a/drivers/gpu/drm/i915/i915_irq.c > >> +++ b/drivers/gpu/drm/i915/i915_irq.c > >> @@ -665,7 +665,8 @@ static int i915_get_vblank_timestamp(struct drm_device *dev, int pipe, > >> crtc); > >> } > >> > >> -static int intel_hpd_irq_event(struct drm_device *dev, struct drm_connector *connector) > >> +static bool intel_hpd_irq_event(struct drm_device *dev, > >> + struct drm_connector *connector) > > > > You change the return value to a bool here, but no users. Missing > > follow-up patch? > > Nope, the only call site in i915_hotplug_work_func() already treats it > as a bool. Somehow I've thought it started out with a void and you switched to bool. Thanks for removing my blinders, patch merged ;-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch