From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Don't enable the cursor on a disable pipe Date: Tue, 17 Sep 2013 19:53:19 +0300 Message-ID: <20130917165319.GY4531@intel.com> References: <1379432024-21194-1-git-send-email-ville.syrjala@linux.intel.com> <1379432024-21194-3-git-send-email-ville.syrjala@linux.intel.com> <20130917162401.GD24051@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20130917162401.GD24051@nuc-i3427.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 17, 2013 at 05:24:01PM +0100, Chris Wilson wrote: > On Tue, Sep 17, 2013 at 06:33:44PM +0300, ville.syrjala@linux.intel.c= om wrote: > > From: Ville Syrj=E4l=E4 > >=20 > > On HSW enabling a plane on a disabled pipe may hang the entire syst= em. > > And there's no good reason for doing it ever, so just don't. > >=20 > > v2: Move the crtc active checks to intel_crtc_cursor_{set,move} to > > avoid confusing people during modeset >=20 > But outside of modeset the existing checks are accurate. There are no existing checks anymore. The crtc->enabled check ended up as collateral damage in the cursor visibility patches. --=20 Ville Syrj=E4l=E4 Intel OTC