From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 5/6] [v3] drm/i915: Use the new vm [un]bind
 functions
Date: Wed, 18 Sep 2013 09:37:41 -0700
Message-ID: <20130918163741.GC9111@bwidawsk.net>
References: <20130917235720.GF24051@nuc-i3427.alporthouse.com>
	<20130918000203.GF6112@bwidawsk.net>
	<20130918083017.GB9223@nuc-i3427.alporthouse.com>
	<20130918144745.GA5225@bwidawsk.net>
	<20130918145337.GC22154@nuc-i3427.alporthouse.com>
	<20130918154845.GB5225@bwidawsk.net>
	<20130918155901.GA2858@nuc-i3427.alporthouse.com>
	<20130918161156.GA9111@bwidawsk.net>
	<20130918161459.GB2858@nuc-i3427.alporthouse.com>
	<CAKMK7uGV2vQuVLi87fvWUs+kAAiE805aGt9fkSFHeFmw8Apnwg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id B0B98E7835
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 18 Sep 2013 09:37:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAKMK7uGV2vQuVLi87fvWUs+kAAiE805aGt9fkSFHeFmw8Apnwg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Sep 18, 2013 at 06:20:23PM +0200, Daniel Vetter wrote:
> On Wed, Sep 18, 2013 at 6:15 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Yes, I want the bug in the code fixed.
> 
> I guess what Ben's trying to say is that right now we don't yet have a
> bug (since we lack the ppgtt address space). But I agree that the fix
> Ben pointed at in this thread of using obj->has_global_mapping won't
> work, we need to pick the address space for the batch offset according
> to the SECURE_DISPATCH flag. And we also need to make sure that we
> actually have the global mapping around.
> 
> Aside: Batch security and ppgtt aren't even fully untangled on hsw,
> afaik only on the render ring do we have seperate bits.
> -Daniel

I see it now. He was trying to solve my trivial bug with the grander
longer term solution. As he requested, I'll just fix the bug for now,
and we can worry about multiple VM support later.

-- 
Ben Widawsky, Intel Open Source Technology Center