From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/4] drm/i915: WARN in case PIPECONF is already enabled Date: Fri, 20 Sep 2013 09:36:44 +0300 Message-ID: <20130920063644.GL4531@intel.com> References: <1379621249-1816-1-git-send-email-przanoni@gmail.com> <1379621249-1816-2-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 11EA3E5DF5 for ; Thu, 19 Sep 2013 23:37:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1379621249-1816-2-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 19, 2013 at 05:07:26PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > = > After the modeset rework this really shouldn't be happening, so > transform it into a WARN. A stuck pipe is a bad signal and is one of > the things that can lead to full machine hangs. > = > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 8fd13ab..5f1399d 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1737,7 +1737,7 @@ static void intel_enable_pipe(struct drm_i915_priva= te *dev_priv, enum pipe pipe, > = > reg =3D PIPECONF(cpu_transcoder); > val =3D I915_READ(reg); > - if (val & PIPECONF_ENABLE) > + if (WARN_ON(val & PIPECONF_ENABLE)) > return; You're forgetting QUIRK_PIPEA_FORCE. > = > I915_WRITE(reg, val | PIPECONF_ENABLE); > -- = > 1.8.3.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC