From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 11/11] drm/i915: Drop explicit plane restoration during resume Date: Fri, 20 Sep 2013 10:41:10 +0300 Message-ID: <20130920074110.GN4531@intel.com> References: <1379342317-27690-1-git-send-email-ville.syrjala@linux.intel.com> <1379342317-27690-12-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 363AAE61A4 for ; Fri, 20 Sep 2013 00:41:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 19, 2013 at 07:24:19PM -0300, Paulo Zanoni wrote: > 2013/9/16 : > > From: Ville Syrj=E4l=E4 > > > > We already restore planes during the modeset operation, so no need to do > > another loop over the planes and try to restore them again. > = > What about the call from intel_lid_notify()? It helps if you explain > on the commit message why/how we already restore things. Sorry, I figured it's more or less obvious: for each crtc -> __intel_set_mode -> .crtc_enable = -> intel_enable_planes -> for each plane on crtc -> intel_plane_restore > = > = > > > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/intel_display.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index c9093bb..37a470f 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -10641,7 +10641,6 @@ void intel_modeset_setup_hw_state(struct drm_de= vice *dev, > > { > > struct drm_i915_private *dev_priv =3D dev->dev_private; > > enum pipe pipe; > > - struct drm_plane *plane; > > struct intel_crtc *crtc; > > struct intel_encoder *encoder; > > int i; > > @@ -10702,8 +10701,6 @@ void intel_modeset_setup_hw_state(struct drm_de= vice *dev, > > __intel_set_mode(crtc, &crtc->mode, crtc->x, cr= tc->y, > > crtc->fb); > > } > > - list_for_each_entry(plane, &dev->mode_config.plane_list= , head) > > - intel_plane_restore(plane); > > } else { > > intel_modeset_update_staged_output_state(dev); > > } > > -- > > 1.8.1.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Paulo Zanoni -- = Ville Syrj=E4l=E4 Intel OTC