From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
Date: Fri, 20 Sep 2013 09:46:05 +0200 [thread overview]
Message-ID: <20130920074604.GF32145@phenom.ffwll.local> (raw)
In-Reply-To: <20130912135236.593fa73d@jbarnes-desktop>
On Thu, Sep 12, 2013 at 01:52:36PM -0700, Jesse Barnes wrote:
> On Thu, 12 Sep 2013 22:38:41 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> > > Unsupported; we just do RC6.
> > >
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > You only change the sysfs stuff here, so I wondered where the hunk for
> > intel_pm.c is. And noticed that we don't actually obey the enable_rc6
> > parameter! Aside: We don't do any such force-to-0 stuff on other
> > platforms, so why do we need this?
>
> Gosh all these questions for such a simple patch.
>
> I was just annoyed that the sysfs rc6 residency test was getting bogus
> values from registers that happened to be there but don't correlate
> with rc6.
Queued for -next, thanks for the patch. I've also pimped the commit
message a bit to explain what's going on.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-09-20 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 20:43 [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT Jesse Barnes
2013-09-11 21:54 ` Chris Wilson
2013-09-11 22:04 ` Jesse Barnes
2013-09-12 20:38 ` Daniel Vetter
2013-09-12 20:52 ` Jesse Barnes
2013-09-20 7:46 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920074604.GF32145@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox