From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp
 residency reporting on BYT
Date: Fri, 20 Sep 2013 09:46:05 +0200
Message-ID: <20130920074604.GF32145@phenom.ffwll.local>
References: <1378932200-1877-1-git-send-email-jbarnes@virtuousgeek.org>
	<20130912203841.GC5459@phenom.ffwll.local>
	<20130912135236.593fa73d@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54])
	by gabe.freedesktop.org (Postfix) with ESMTP id 700DFE68C5
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 20 Sep 2013 00:45:50 -0700 (PDT)
Received: by mail-ee0-f54.google.com with SMTP id e53so50530eek.27
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 20 Sep 2013 00:45:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130912135236.593fa73d@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Sep 12, 2013 at 01:52:36PM -0700, Jesse Barnes wrote:
> On Thu, 12 Sep 2013 22:38:41 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> > > Unsupported; we just do RC6.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > You only change the sysfs stuff here, so I wondered where the hunk for
> > intel_pm.c is. And noticed that we don't actually obey the enable_rc6
> > parameter! Aside: We don't do any such force-to-0 stuff on other
> > platforms, so why do we need this?
> 
> Gosh all these questions for such a simple patch.
> 
> I was just annoyed that the sysfs rc6 residency test was getting bogus
> values from registers that happened to be there but don't correlate
> with rc6.

Queued for -next, thanks for the patch. I've also pimped the commit
message a bit to explain what's going on.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch