From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 10/11] drm/i915: Call intel_uncore_early_sanitize() during resume
Date: Fri, 20 Sep 2013 10:59:10 +0300 [thread overview]
Message-ID: <20130920075910.GO4531@intel.com> (raw)
In-Reply-To: <CA+gsUGTghureyd=A-s-4nZW2qbfEWKk65zW+fR2V_Pp32aKusg@mail.gmail.com>
On Thu, Sep 19, 2013 at 07:18:54PM -0300, Paulo Zanoni wrote:
> 2013/9/16 <ville.syrjala@linux.intel.com>:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Call intel_uncore_early_sanitize() first thing during resume to prevent
> > stale BIOS leftovers from being reported as unclaimed register access.
>
> Just out of curiosity: do you actually need this patch to avoid error
> messages? The change makes sense, but since we didn't need it so far,
> I wonder if maybe it's something we're doing wrong that's causing the
> need to sanitize.
It does get rid of an error message on my HSW machine during hibernate.
I just noticed that I didn't have CONFIG_SND_HDA_I915 enabled, but I
just tried to enable it and I still got the error. The latest BIOS
didn't fix it either. And I also tried to clear the error as the last
thing before we suspend the device, and that didn't help either. So it
does look like the BIOS does something silly.
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index fdf3eef..3d25731 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -670,6 +670,8 @@ int i915_resume(struct drm_device *dev)
> >
> > pci_set_master(dev->pdev);
> >
> > + intel_uncore_early_sanitize(dev);
> > +
> > intel_uncore_sanitize(dev);
> >
> > /*
> > --
> > 1.8.1.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
> --
> Paulo Zanoni
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-20 7:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:38 [PATCH 00/11] drm/i915: VGA vs. power well, round 2 ville.syrjala
2013-09-16 14:38 ` [PATCH v2 01/11] drm/i915: Change i915_request power well handling ville.syrjala
2013-09-16 17:33 ` Paulo Zanoni
2013-09-17 11:35 ` Ville Syrjälä
2013-09-16 14:38 ` [PATCH v2 02/11] drm/i915: Add intel_display_power_{get, put} to request power for specific domains ville.syrjala
2013-09-16 14:38 ` [PATCH v2 03/11] drm/i915: Refactor power well refcount inc/dec operations ville.syrjala
2013-09-16 14:38 ` [PATCH 04/11] drm/i915: Add POWER_DOMAIN_VGA ville.syrjala
2013-09-16 14:38 ` [PATCH 05/11] drm/i915: Pull intel_init_power_well() out of intel_modeset_init_hw() ville.syrjala
2013-09-19 22:07 ` Paulo Zanoni
2013-09-20 8:41 ` Daniel Vetter
2013-09-16 14:38 ` [PATCH 06/11] drm/i915: Fix unclaimed register access due to delayed VGA memroy disable ville.syrjala
2013-09-19 22:05 ` Paulo Zanoni
2013-09-20 7:10 ` Ville Syrjälä
2013-09-20 7:14 ` [PATCH v2 " ville.syrjala
2013-09-23 16:48 ` Paulo Zanoni
2013-09-24 8:50 ` Daniel Vetter
2013-09-16 14:38 ` [PATCH 07/11] drm/i915: Redisable VGA before the modeset on resume ville.syrjala
2013-09-19 22:07 ` Paulo Zanoni
2013-09-16 14:38 ` [PATCH 08/11] drm/i915: Move power well init earlier during driver load ville.syrjala
2013-09-16 14:38 ` [PATCH 09/11] drm/i915: Move power well resume earlier ville.syrjala
2013-09-19 22:15 ` Paulo Zanoni
2013-09-16 14:38 ` [PATCH 10/11] drm/i915: Call intel_uncore_early_sanitize() during resume ville.syrjala
2013-09-19 22:18 ` Paulo Zanoni
2013-09-20 7:59 ` Ville Syrjälä [this message]
2013-09-16 14:38 ` [PATCH 11/11] drm/i915: Drop explicit plane restoration " ville.syrjala
2013-09-19 22:24 ` Paulo Zanoni
2013-09-20 7:41 ` Ville Syrjälä
2013-09-20 16:22 ` Paulo Zanoni
2013-09-20 18:21 ` Paulo Zanoni
2013-09-21 12:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920075910.GO4531@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox