From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/11] drm/i915: Call intel_uncore_early_sanitize() during resume Date: Fri, 20 Sep 2013 10:59:10 +0300 Message-ID: <20130920075910.GO4531@intel.com> References: <1379342317-27690-1-git-send-email-ville.syrjala@linux.intel.com> <1379342317-27690-11-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 71880E5FA1 for ; Fri, 20 Sep 2013 00:59:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 19, 2013 at 07:18:54PM -0300, Paulo Zanoni wrote: > 2013/9/16 : > > From: Ville Syrj=E4l=E4 > > > > Call intel_uncore_early_sanitize() first thing during resume to prevent > > stale BIOS leftovers from being reported as unclaimed register access. > = > Just out of curiosity: do you actually need this patch to avoid error > messages? The change makes sense, but since we didn't need it so far, > I wonder if maybe it's something we're doing wrong that's causing the > need to sanitize. It does get rid of an error message on my HSW machine during hibernate. I just noticed that I didn't have CONFIG_SND_HDA_I915 enabled, but I just tried to enable it and I still got the error. The latest BIOS didn't fix it either. And I also tried to clear the error as the last thing before we suspend the device, and that didn't help either. So it does look like the BIOS does something silly. > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/i915_drv.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i91= 5_drv.c > > index fdf3eef..3d25731 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -670,6 +670,8 @@ int i915_resume(struct drm_device *dev) > > > > pci_set_master(dev->pdev); > > > > + intel_uncore_early_sanitize(dev); > > + > > intel_uncore_sanitize(dev); > > > > /* > > -- > > 1.8.1.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Paulo Zanoni -- = Ville Syrj=E4l=E4 Intel OTC